feat: basic limit orders #2649

JoaquinBattilana · 2025-09-19T07:41:15Z

General Changes

Fixes XYZ bug
Adds XYZ feature
…

Developer Notes

Add any notes here that may be helpful for reviewers.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

vercel · 2025-09-19T07:41:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
interface	Ready	Preview	Comment	Oct 1, 2025 3:17pm

Copilot

Pull Request Overview

This PR introduces basic limit order functionality to the swap interface by implementing a new limit order mode that operates alongside the existing market order functionality. It adds the ability for users to create conditional trades that execute when specific price conditions are met.

Key changes include:

New limit order modal component with price input functionality and expiry settings
Integration of CoW Protocol's limit order API for order creation and management
Enhanced market configuration to enable limit order features on specific networks

Reviewed Changes

Copilot reviewed 20 out of 24 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/hooks/useStaticRate.ts	New hook for fetching static exchange rates between token pairs
src/hooks/useGetConnectedWalletType.ts	New utility hook to detect smart contract and Safe wallet types
src/hooks/switch/useCowSwitchRates.ts	New hook for fetching CoW Protocol rates with limit order support
src/hooks/switch/cowprotocol.rates.ts	Exports getTokenUsdPrice function for external use and updates return type
src/components/transactions/Switch/SwitchTypeSelector.tsx	New component for toggling between market and limit order modes
src/components/transactions/Switch/SwitchModal.tsx	Refactored to support both market and limit order types
src/components/transactions/Switch/SwitchLimitOrdersModalContent.tsx	Main limit order interface with price inputs and order management
src/components/transactions/Switch/SwitchLimitOrdersActions.tsx	Action handlers for creating and managing limit orders
src/components/transactions/Switch/PriceInput.tsx	Price input component for setting limit order execution rates
src/components/transactions/Switch/ExpirySelector.tsx	Component for selecting order expiration timeframes
src/ui-config/marketsConfig.tsx	Enables limit order feature for mainnet and arbitrum markets
src/utils/events.ts	Adds tracking events for switch modal interactions
src/locales/en/messages.po	Adds localization strings for limit order UI elements

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-23T16:15:26Z

src/components/transactions/Switch/SwitchLimitOrdersModalContent.tsx

+        loading={rateLoading}
+        rate={rate}
+        rateUsd={'0'}
+        switchRate={console.log}


The switchRate prop is set to console.log which is likely a debugging leftover. This should be replaced with an actual function or removed if not needed.

Suggested change

switchRate={console.log}

Copilot · 2025-09-23T16:15:26Z

src/components/transactions/Switch/SwitchLimitOrdersModalContent.tsx

+  const [expiry, setExpiry] = useState(Expiry['One week']);
+
+  const [inputAmount, setInputAmount] = useState('');
+  // const [outputAmount, setOutputAmount] = useState('');


Remove commented out code that is not being used.

Suggested change

// const [outputAmount, setOutputAmount] = useState('');

Copilot · 2025-09-23T16:15:27Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  const [
+    user,
+    //addTransaction,
+    currentMarketData,
+    trackEvent,
+  ] = useRootStore(
+    useShallow((state) => [
+      state.account,
+      //state.addTransaction,
+      state.currentMarketData,
+      state.trackEvent,
+    ])
+  );


Remove commented out code references to addTransaction that are not being used.

Copilot · 2025-09-23T16:15:27Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  // // Track execution state to pause rate updates during actions
+  // useEffect(() => {
+  //   const isExecuting = mainTxState.loading || approvalTxState.loading || loadingTxns;
+
+  //   setIsExecutingActions?.(isExecuting);
+  // }, [mainTxState.loading, approvalTxState.loading, loadingTxns, setIsExecutingActions]);
+
+  // useEffect(() => {
+  //   let switchGasLimit = 0;
+  //   if (requiresApproval && !approvalTxState.success) {
+  //     switchGasLimit += Number(APPROVAL_GAS_LIMIT);
+  //     if (requiresApprovalReset) {
+  //       switchGasLimit += Number(APPROVAL_GAS_LIMIT); // Reset approval
+  //     }
+  //   }
+  //   if (isNativeToken(inputToken)) {
+  //     switchGasLimit += Number(
+  //       gasLimitRecommendations[ProtocolAction.withdrawAndSwitch].recommended
+  //     );
+  //   }
+  //   setGasLimit(switchGasLimit.toString());
+  //   setShowGasStation(requiresApproval || isNativeToken(inputToken));
+  // }, [requiresApproval, approvalTxState, setGasLimit, setShowGasStation, requiresApprovalReset]);


Remove large blocks of commented out code. If this functionality is needed later, it can be retrieved from version control.

Copilot · 2025-09-23T16:15:28Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  inputToken: TokenInfoWithBalance;
+  outputToken: TokenInfoWithBalance;
+  outputAmount: string;
+  //setShowUSDTResetWarning: (showUSDTResetWarning: boolean) => void;


Remove commented out interface properties and parameter destructuring that are not being used.

Copilot · 2025-09-23T16:15:28Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  inputAmount,
+  inputToken,
+  outputToken,
+  //setShowUSDTResetWarning,


Remove commented out interface properties and parameter destructuring that are not being used.

Copilot · 2025-09-23T16:15:28Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  //setShowUSDTResetWarning: (showUSDTResetWarning: boolean) => void;
+  blocked: boolean;
+  loading?: boolean;
+  isWrongNetwork: boolean;
+  chainId: number;
+  //setShowGasStation: (showGasStation: boolean) => void;
+  poolReserve?: ComputedReserveData;
+  targetReserve?: ComputedReserveData;
+  // setIsExecutingActions?: (isExecuting: boolean) => void;
+}
+
+export const SwitchLimitOrdersActions = ({
+  inputAmount,
+  inputToken,
+  outputToken,
+  //setShowUSDTResetWarning,
+  blocked,
+  loading,
+  isWrongNetwork,
+  chainId,
+  outputAmount,
+}: // setShowGasStation,
+// setIsExecutingActions,


Remove commented out interface properties and parameter destructuring that are not being used.

Suggested change

//setShowUSDTResetWarning: (showUSDTResetWarning: boolean) => void;

blocked: boolean;

loading?: boolean;

isWrongNetwork: boolean;

chainId: number;

//setShowGasStation: (showGasStation: boolean) => void;

poolReserve?: ComputedReserveData;

targetReserve?: ComputedReserveData;

// setIsExecutingActions?: (isExecuting: boolean) => void;

}

export const SwitchLimitOrdersActions = ({

inputAmount,

inputToken,

outputToken,

//setShowUSDTResetWarning,

blocked,

loading,

isWrongNetwork,

chainId,

outputAmount,

}: // setShowGasStation,

// setIsExecutingActions,

blocked: boolean;

loading?: boolean;

isWrongNetwork: boolean;

chainId: number;

poolReserve?: ComputedReserveData;

targetReserve?: ComputedReserveData;

}

export const SwitchLimitOrdersActions = ({

inputAmount,

inputToken,

outputToken,

blocked,

loading,

isWrongNetwork,

chainId,

outputAmount,

Copilot · 2025-09-23T16:15:29Z

src/locales/en/messages.po


+#: src/components/transactions/Switch/ExpirySelector.tsx
+msgid "{key}"
+msgstr "{key}"


The localization entry '{key}' appears to be a placeholder. This should be replaced with actual descriptive text or the translation logic should be updated to handle dynamic keys properly.

Suggested change

msgstr "{key}"

msgstr "Unknown key: {key}"

mgrabina · 2025-09-24T21:19:24Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+  const {
+    data: approvedAmount,
+    isFetching: fetchingApprovedAmount,
+    refetch: fetchApprovedAmount,
+  } = useApprovedAmount({
+    chainId,
+    token: inputToken.address,
+    spender: COW_PROTOCOL_VAULT_RELAYER_ADDRESS[chainId as SupportedChainId],
+  });
+
+  setLoadingTxns(fetchingApprovedAmount);
+
+  let requiresApproval = false;
+  if (approvedAmount !== undefined) {
+    requiresApproval = checkRequiresApproval({
+      approvedAmount: approvedAmount.toString(),
+      amount: inputAmount,
+      signedAmount: '0',
+    });
+  }
+


USDT requires reset in mainnet

mgrabina · 2025-09-24T21:20:17Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+    const tradingSdk = new TradingSdk({ chainId, signer, appCode: HEADER_WIDGET_APP_CODE });
+    const receipt = await tradingSdk.postLimitOrder({
+      sellAmount: parseUnits(inputAmount, inputToken.decimals).toString(),
+      buyAmount: parseUnits(outputAmount, outputToken.decimals).toString(),
+      kind: OrderKind.SELL,
+      sellToken: inputToken.address,
+      buyToken: outputToken.address,
+      sellTokenDecimals: inputToken.decimals,
+      buyTokenDecimals: outputToken.decimals,
+      validFor: 86400, // 24 hours
+    });


we should re-use helpers in cow herlpers file to avoid missing stuff we learned in past integrations, e.g. partnerfee.

I dont think there is a function there that can be used, maybe getUnsignedOrder could work with a little rework

mgrabina · 2025-09-24T21:20:26Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+      buyToken: outputToken.address,
+      sellTokenDecimals: inputToken.decimals,
+      buyTokenDecimals: outputToken.decimals,
+      validFor: 86400, // 24 hours


this shoul;d come from the picker right?

mgrabina · 2025-09-24T21:20:45Z

src/components/transactions/Switch/SwitchLimitOrdersActions.tsx

+    const receipt = await tradingSdk.postLimitOrder({
+      sellAmount: parseUnits(inputAmount, inputToken.decimals).toString(),
+      buyAmount: parseUnits(outputAmount, outputToken.decimals).toString(),
+      kind: OrderKind.SELL,


for limit orders we should be able to support buy orders by changing the buy side right?

grothem · 2025-09-29T19:32:58Z

Would be nice if we could have the history item show 'Limit Order' instead of 'Swap'

interface/src/modules/history/actions/ActionDetails.tsx

Line 41 in dfc252d

return <Trans>Swap</Trans>;

foodaka · 2025-09-30T14:08:31Z

pages/_app.page.tsx

+const CancelCowOrderModal = dynamic(() =>
+  import('src/components/transactions/CancelCowOrder/CancelCowOrderModal').then(
+    (module) => module.CancelCowOrderModal
+  )
+);


thanks for adding

github-actions · 2025-09-30T15:35:18Z

Ipfs hash: bafybeihoxxcgizu25uzqyshjhdlfmjtasqnkd7u4bu6kr5u6i6dhcjtd74
Ipfs preview link: https://bafybeihoxxcgizu25uzqyshjhdlfmjtasqnkd7u4bu6kr5u6i6dhcjtd74.ipfs.cf-ipfs.com/

github-actions · 2025-09-30T15:35:31Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-01T14:51:10Z

Ipfs hash: bafybeigmt6amfz2i42zlrz74txfmpxvr2jcsn76uk67y336dqyyjfvoar4
Ipfs preview link: https://bafybeigmt6amfz2i42zlrz74txfmpxvr2jcsn76uk67y336dqyyjfvoar4.ipfs.cf-ipfs.com/

github-actions · 2025-10-01T14:51:24Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-10-01T15:21:34Z

Ipfs hash: bafybeifj43npxqchm33x57eyz3uhjrg7kkyux5nt2wufehnjy3h2hurbxi
Ipfs preview link: https://bafybeifj43npxqchm33x57eyz3uhjrg7kkyux5nt2wufehnjy3h2hurbxi.ipfs.cf-ipfs.com/

github-actions · 2025-10-01T15:21:43Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

feat: basic limit orders

5bb8632

vercel bot had a problem deploying to Preview September 19, 2025 07:43 Failure

JoaquinBattilana added 2 commits September 22, 2025 02:19

Merge branch 'main' into feat/switch-limit-2

17c959b

feat: fixes allaround

dd15ecf

vercel bot deployed to Preview September 23, 2025 06:51 View deployment

foodaka requested a review from Copilot September 23, 2025 16:13

Copilot AI reviewed Sep 23, 2025

View reviewed changes

mgrabina reviewed Sep 24, 2025

View reviewed changes

feat: fixes

6862f38

vercel bot deployed to Preview September 26, 2025 07:45 View deployment

feat: fee

de28149

vercel bot deployed to Preview September 29, 2025 13:32 View deployment

feat: cancel order

2a44d4d

vercel bot deployed to Preview September 30, 2025 07:53 View deployment

foodaka reviewed Sep 30, 2025

View reviewed changes

feat: merged with main

5d3b88c

vercel bot deployed to Preview September 30, 2025 15:33 View deployment

feat: fixed rates

fd57231

vercel bot deployed to Preview September 30, 2025 18:54 View deployment

JoaquinBattilana added 2 commits September 30, 2025 16:16

feat: desc texts

7e8bae9

feat: fix loading issue

4e31821

vercel bot deployed to Preview September 30, 2025 20:04 View deployment

feat: small nits

a519e9e

vercel bot deployed to Preview October 1, 2025 06:27 View deployment

chore: merged with main

0bbd7e2

vercel bot deployed to Preview October 1, 2025 14:49 View deployment

feat: tracking and arbitrum

567f90e

vercel bot deployed to Preview October 1, 2025 15:17 View deployment

foodaka approved these changes Oct 1, 2025

View reviewed changes

mgrabina approved these changes Oct 1, 2025

View reviewed changes

JoaquinBattilana merged commit dc32c18 into main Oct 1, 2025
19 of 21 checks passed

JoaquinBattilana deleted the feat/switch-limit-2 branch October 1, 2025 15:57

feat: basic limit orders #2649

feat: basic limit orders #2649

Uh oh!

Conversation

JoaquinBattilana commented Sep 19, 2025

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

vercel bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

mgrabina Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

mgrabina Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

JoaquinBattilana Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

mgrabina Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

mgrabina Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

grothem commented Sep 29, 2025

Uh oh!

foodaka Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Sep 19, 2025 •

edited

Loading