fix: incomplete string escaping #2660
Conversation
mgrabina
commented
Sep 23, 2025
mgrabina
commented
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.43 MB (🟡 +4.57 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Sixteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
60.74 KB (🟡 +1.15 KB) |
1.49 MB |
/404 |
2.79 KB (🟡 +327 B) |
1.43 MB |
/500 |
3.19 KB (🟡 +283 B) |
1.43 MB |
/bridge |
33.75 KB (🟡 +309 B) |
1.46 MB |
/dashboard |
51.89 KB (🟡 +952 B) |
1.48 MB |
/faucet |
15.21 KB (🟡 +309 B) |
1.44 MB |
/governance |
80.81 KB (🟡 +196 B) |
1.51 MB |
/governance/ipfs-preview |
100.63 KB (🟡 +966 B) |
1.53 MB |
/governance/v3/proposal |
122.85 KB (🟡 +109 B) |
1.55 MB |
/history |
24.04 KB (🟡 +311 B) |
1.45 MB |
/markets |
35.91 KB (🟡 +2.29 KB) |
1.46 MB |
/reserve-overview |
23.31 KB (🟡 +293 B) |
1.45 MB |
/safety-module |
37.37 KB (🟡 +346 B) |
1.47 MB |
/sgho |
79.28 KB (🟡 +322 B) |
1.51 MB |
/staking |
32.11 KB (🟡 +309 B) |
1.46 MB |
/v3-migration |
35.51 KB (🟡 +311 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
mgrabina
requested review from
absis,
foodaka,
JoaquinBattilana,
grothem and
AGMASO
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| const src = /^\.\.\//.test(_src) | ||
| ? _src.replace( | ||
| '../', | ||
| /\.\.\//g, | ||
| 'https://raw.githubusercontent.com/aave/aip/main/content/' |
There was a problem hiding this comment.
[P1] Replace only leading relative segments in image URLs
The new replace(/\.\.\//g, ...) now substitutes every ../ in the image path with the absolute raw GitHub prefix. Paths that traverse multiple parent directories (e.g. ../../images/foo.png) will be rewritten to https://raw…https://raw…images/foo.png, which 404s. The previous implementation replaced only the leading segment and let the remaining ../ resolve naturally. Limiting the replacement to the leading occurrence (e.g. replace(/^\.\.\//, ...)) avoids duplicating the prefix while still handling literal dots correctly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex can you do the change?
There was a problem hiding this comment.
@codex fix comments
There was a problem hiding this comment.
Summary
- Limited the proposal markdown image rewriting to only replace the leading
../segment, preventing duplicated raw GitHub prefixes in nested paths. src/modules/governance/proposal/ProposalOverview.tsxL196-L204
Testing
⚠️ Not run (not requested)
There was a problem hiding this comment.
Summary
- Limited the markdown image URL normalization to replace only the leading
../segment so deeper relative paths remain valid. src/modules/governance/proposal/ProposalOverview.tsxL196-L204
Testing
⚠️ Not run (not requested).
|
@codex fix comments |
|
Summary
Testing
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.43 MB (🟡 +4.56 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Sixteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
60.74 KB (🟡 +1.15 KB) |
1.49 MB |
/404 |
2.79 KB (🟡 +327 B) |
1.43 MB |
/500 |
3.19 KB (🟡 +283 B) |
1.43 MB |
/bridge |
33.75 KB (🟡 +309 B) |
1.46 MB |
/dashboard |
51.89 KB (🟡 +952 B) |
1.48 MB |
/faucet |
15.21 KB (🟡 +309 B) |
1.44 MB |
/governance |
80.81 KB (🟡 +196 B) |
1.51 MB |
/governance/ipfs-preview |
100.63 KB (🟡 +964 B) |
1.53 MB |
/governance/v3/proposal |
122.85 KB (🟡 +107 B) |
1.55 MB |
/history |
24.04 KB (🟡 +311 B) |
1.45 MB |
/markets |
35.91 KB (🟡 +2.29 KB) |
1.46 MB |
/reserve-overview |
23.31 KB (🟡 +293 B) |
1.45 MB |
/safety-module |
37.37 KB (🟡 +346 B) |
1.47 MB |
/sgho |
79.28 KB (🟡 +322 B) |
1.51 MB |
/staking |
32.11 KB (🟡 +309 B) |
1.46 MB |
/v3-migration |
35.51 KB (🟡 +311 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
