Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add french #447

Merged
merged 4 commits into from
Mar 10, 2022
Merged

feat: add french #447

merged 4 commits into from
Mar 10, 2022

Conversation

sakulstra
Copy link
Collaborator

@sakulstra sakulstra commented Mar 10, 2022

  1. adjust configs according to the first commit
  2. run yarn i18n:extract to add the new language to en translations
  3. run yarn i18n:extract --locale fr to seed the initial language file
  4. run yarn i18n:compile to compile the po files to js

now your settled and the ci takes over

@sakulstra sakulstra merged commit 55e6f07 into master Mar 10, 2022
@sakulstra sakulstra deleted the feat/add-french branch March 10, 2022 18:05
@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.19 MB (🟡 +61 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 48.62 KB (🟡 +8 B) 1.24 MB
/faucet 20.25 KB (🟡 +8 B) 1.21 MB
/governance 74.99 KB (🟡 +8 B) 1.26 MB
/governance/proposal 113.34 KB (🟡 +8 B) 1.3 MB
/governance/proposal/[proposalId] 68.17 KB (🟡 +8 B) 1.26 MB
/markets 23.11 KB (🟡 +8 B) 1.21 MB
/reserve-overview 79.05 KB (🟡 +8 B) 1.27 MB
/staking 44.14 KB (🟡 +8 B) 1.23 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant