feat: add optional errorCallback #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With google or other providers you can get following error when you are browsing in private modus: ````error: "idpiframe_initialization_failed", details: "Cookies are not enabled in current environment."``` In this case I want to inform the user instead of having a silence error. My proposal is to add an erroCallback, where you can add an alert or something else to avoid that the user is not informed.
jaibatrik
reviewed
Sep 4, 2020
|
@jaibatrik If you find a better name, let me know. But I have no idea neither |
|
I think, we can name it |
|
@jaibatrik I've renamed it, so it will be ready to merge I guess? |
jaibatrik
approved these changes
Sep 16, 2020
|
Thanks, I'll push this to npm in a few days. |
|
Holding on for the refactor related to #280. |
|
Pushed this to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With google or other providers you can get following error when you are browsing in private modus:
error: "idpiframe_initialization_failed", details: "Cookies are not enabled in current environment."In this case I want to inform the user instead of having a silence error. My proposal is to add an erroCallback, where you can add an alert or something else to avoid that the user is not informed.