Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] itp_support attr to Google btn #581

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[Add] itp_support attr to Google btn #581

merged 1 commit into from
Aug 19, 2022

Conversation

NicolasRoehm
Copy link
Contributor

I added itp_support boolean attribute to GoogleSigninButtonDirective. This allows users to disable the One Tap window in case we just want the button.

Sources :
HTML API reference : data-itp_support
Understand One Tap User Experience : Upgraded UX on ITP browsers

Example :
One Tap UX

@Heatmanofurioso Heatmanofurioso merged commit e4521f3 into abacritt:master Aug 19, 2022
@Heatmanofurioso Heatmanofurioso added the enhancement Feature requests or enhancements label Aug 19, 2022
@kattoshi
Copy link
Contributor

Build fails in my environment.
Does the build succeed?

------------------------------------------------------------------------------
Building entry point '@abacritt/angularx-social-login'
------------------------------------------------------------------------------
✖ Compiling with Angular sources in Ivy full compilation mode.
projects/lib/src/directives/google-signin-button.directive.ts:63:13 - error TS2345: Argument of type '{ type: "standard" | "icon"; size: "small" | "medium" | "large"; text: "signin_with" | "signup_with"; width: string; shape: "square" | "circle" | "pill" | "rectangular"; theme: "outline" | "filled_blue" | "filled_black"; logo_alignment: "center" | "left"; locale: string; itp_support: boolean; }' is not assignable to parameter of type 'GsiButtonConfiguration'.
  Object literal may only specify known properties, and 'itp_support' does not exist in type 'GsiButtonConfiguration'.

63             itp_support: this.itp_support,
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants