Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline replies and default intents #1027

Closed
wants to merge 5 commits into from
Closed

Inline replies and default intents #1027

wants to merge 5 commits into from

Conversation

bsian03
Copy link
Collaborator

@bsian03 bsian03 commented Oct 2, 2020 •
edited
Loading

Default to v8 gateway and REST versions, as a result, also add default intents.
Adds inline replies which are not live yet but referenced as per discord/discord-api-docs#2118

EDIT: @Khaaz wanted me to revert back to v7 REST and v6 gateway as he had other stuff planned for v8 which would cause a bit of a mess with this PR

@bsian03 bsian03 marked this pull request as draft October 2, 2020 17:18
@bsian03 bsian03 changed the title Gateway/REST v8 update Gateway/REST v8 preparations Oct 2, 2020
@bsian03 bsian03 changed the title Gateway/REST v8 preparations Inline replies and default intents Oct 4, 2020
@bsian03 bsian03 marked this pull request as ready for review October 4, 2020 11:07
@Yamboy1
Copy link

Yamboy1 commented Oct 30, 2020

Maybe I don't have a proper understanding of intents, but imo defaulting to using all intents (bar the privileged intents) kinda seems like it's undoing the work of intents entirely. I would expect most people would leave this default unless they need the privileged intents, rather than only requesting the intents that they need. As well as that, for people that don't need any intents, I would expect just leaving the parameter blank would be fine, but in this case it would be sending almost all the intents?

@bsian03
Copy link
Collaborator Author

bsian03 commented Oct 31, 2020

Completely get your thought here - I thought the "general" user who had no idea what intents are would benefit from this, hence why the PR exists. Of course people can choose which intents they need, that's up to their own discretion and their fault if something breaks. I just set this up with a "get started quicker and sort it out later" mindset

@bsian03 bsian03 marked this pull request as draft November 16, 2020 23:08
@bsian03
Copy link
Collaborator Author

bsian03 commented Nov 16, 2020

Going to double check if everything is up to date before I mark this as ready again

Dragory
Dragory reviewed Nov 17, 2020
View reviewed changes
lib/structures/Message.js
}
if(data.referenced_message !== undefined) {
this.referencedMessage = this.channel.messages.get(data.referenced_message.id) || new Message(data.referenced_message, this._client);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated?

@bsian03
Copy link
Collaborator Author

bsian03 commented Nov 17, 2020

Going to split the PR

This was referenced Nov 17, 2020
Merged
Closed
@bsian03
Copy link
Collaborator Author

bsian03 commented Nov 17, 2020

PR split to the 2 above

@bsian03 bsian03 closed this Nov 17, 2020
@bsian03 bsian03 deleted the v8 branch November 18, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragory Dragory Dragory left review comments

Assignees
No one assigned
Labels
Discord duplicate enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bsian03 @Yamboy1 @Dragory @abalabahaha