Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position to CreateChannelOptions #1340

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Add position to CreateChannelOptions #1340

merged 2 commits into from
Mar 9, 2022

Conversation

frobinsonj
Copy link
Contributor

@frobinsonj frobinsonj commented Feb 14, 2022

position should be included as an optional parameter when creating or modifying a guild channel.

Create: https://discord.com/developers/docs/resources/guild#:~:text=%2C%20are%20unaffected-,position,-integer

Modify: https://discord.com/developers/docs/resources/channel#:~:text=Text%2C%20News-,position,-%3Finteger

NOTE: Also fixed the order of options parameters in GuildChannel#edit() (should have been alphabetical)

Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, but lgtm

@curtisf curtisf merged commit bb8a45e into abalabahaha:dev Mar 9, 2022
@frobinsonj frobinsonj deleted the add-createchannel-position branch April 30, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants