Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Guild): Edit MFA level #1473

Merged
merged 10 commits into from
Jan 22, 2024
Merged

feat(Guild): Edit MFA level #1473

merged 10 commits into from
Jan 22, 2024

Conversation

conorwastakenwastaken
Copy link
Contributor

@conorwastakenwastaken conorwastakenwastaken commented Jan 17, 2024 •
edited
Loading

bsian03
bsian03 requested changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

index.d.ts Outdated Show resolved Hide resolved
@bsian03 bsian03 mentioned this pull request Jan 19, 2024
Open
55 tasks
bsian03
bsian03 requested changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API actually returns { level: number }. Also please specify that the bot needs to be the guild owner for it to work

@bsian03
Copy link
Collaborator

bsian03 commented Jan 22, 2024

Tested on 5da4537, no actual code changes since conorwastakenwastaken/eris@5da4537...6bcbb02 - Shard and createGuild edits are PR merges.
Will merge once I get to test typings

bsian03
bsian03 requested changes Jan 22, 2024
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@bsian03 bsian03 merged commit 3b0dd35 into abalabahaha:dev Jan 22, 2024
@conorwastakenwastaken conorwastakenwastaken deleted the mfalevels branch January 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsian03 bsian03 bsian03 approved these changes

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorwastakenwastaken @bsian03