Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Locales): add discord supported locales #1484

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

YetAnotherConnor
Copy link
Contributor

Added list of discord supported locales to help localization typings.

I am unsure if there is any modifications needed to the jsdocs

@bsian03 bsian03 added the Discord label Feb 4, 2024
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a type alias for the locales constant

Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda surprised locales aren't in alphabetical order on discord docs.. would love for them to be organised here though (by ISO 639)

@bsian03
Copy link
Collaborator

bsian03 commented Feb 16, 2024

you ordered them by name, not by iso639-1

@YetAnotherConnor
Copy link
Contributor Author

My apologies, the ISO 639 list I found was ordered by the English key. I have now ordered the locales by their value

@bsian03 bsian03 merged commit f09ba3e into abalabahaha:dev Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants