-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Locales): add discord supported locales #1484
feat(Locales): add discord supported locales #1484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a type alias for the locales constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda surprised locales aren't in alphabetical order on discord docs.. would love for them to be organised here though (by ISO 639)
you ordered them by name, not by iso639-1 |
My apologies, the ISO 639 list I found was ordered by the English key. I have now ordered the locales by their value |
Added list of discord supported locales to help localization typings.
I am unsure if there is any modifications needed to the jsdocs