make ifconfig parameters optional

abandonware · Apr 3, 2017 · f4ad465 · f4ad465
1 parent ba836ee
commit f4ad465
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/ifconfig.js b/ifconfig.js
@@ -236,14 +236,16 @@ function down(interface, callback) {
  * };
  *
  * ifconfig.up(options, function(err) {
- *   // the interface is up 
+ *   // the interface is up
  * });
  *
+ * ipv4_address, ipv4_broadcast and ipv4_subnet_mask are optional
  */
 function up(options, callback) {
   return this.exec('ifconfig ' + options.interface +
-    ' ' + options.ipv4_address +
-    ' netmask ' + options.ipv4_subnet_mask +
-    ' broadcast ' + options.ipv4_broadcast +
+    ' ' +
+    (options.ipv4_address ? options.ipv4_address : '0.0.0.0') +
+    (options.ipv4_subnet_mask ? ' netmask ' + options.ipv4_subnet_mask : '') +
+    (options.ipv4_broadcast ? ' broadcast ' + options.ipv4_broadcast : '') +
     ' up', callback);
 }