Open Repository in ext browser with linked branch #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamWaghmare-sap
requested changes
Nov 14, 2024
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
shubhamWaghmare-sap
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Hi Aarnav,
Thanks for the requested changes & info.
I have added some more comments.
Please check them & make changes accordingly.
These are mostly code style changes & can be debated.
But take time to understand the reasoning behind the requested change & we can discuss if you have doubts.
Also, feel free to question any change request.
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
shubhamWaghmare-sap
requested changes
Dec 17, 2024
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
...bapgit.adt.ui/src/org/abapgit/adt/ui/internal/repositories/actions/OpenRepositoryAction.java
Outdated
Show resolved
Hide resolved
shubhamWaghmare-sap
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow update:
Earlier:
Now