forked from vkurchatkin/deasync
-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Promises/await support #90
Open
egormalyutin
wants to merge
9
commits into
abbr:master
Choose a base branch
from
egormalyutin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
553b300
add promise support
55c7d46
add promise support
9a7ea2f
add promise support
0c115d5
export default & index.d.ts
bluelovers b3968d9
export default & index.d.ts
bluelovers 6d17307
demo
bluelovers c87c3e3
return value at source Promise
bluelovers fe9129d
Merge pull request #1 from bluelovers/master
643be23
Add error handler in Promise
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/** | ||
* Created by user on 2018/4/13/013. | ||
*/ | ||
|
||
declare namespace DeAsync | ||
{ | ||
export interface IApi | ||
{ | ||
<T>(fn: (argv, done: <U extends Error>(err: U, value: T) => never) => T, ...argv): T, | ||
<T>(fn: (done: <U extends Error>(err: U, value: T) => never) => T, ...argv): T, | ||
<T>(fn: (...argv) => T, ...argv): T, | ||
|
||
sleep(timeout: number): never, | ||
runLoopOnce(): never, | ||
loopWhile(pred: (...argv) => boolean): never, | ||
await<T>(pr: Promise<T>): T | ||
|
||
default: IApi, | ||
} | ||
} | ||
|
||
declare const DeAsync: DeAsync.IApi; | ||
export = DeAsync; | ||
|
||
export as namespace DeAsync; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ | |
"async", | ||
"sync", | ||
"sleep", | ||
"await", | ||
"promise", | ||
"async wrapper" | ||
], | ||
"engines": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/** | ||
* Created by user on 2018/4/13/013. | ||
*/ | ||
|
||
const deasync = require(".."); | ||
const timstamp = Date.now(); | ||
|
||
function f(n) | ||
{ | ||
return new Promise(function (done) | ||
{ | ||
setTimeout(done, n); | ||
}) | ||
.then(function () | ||
{ | ||
logWithTime(n); | ||
}); | ||
} | ||
|
||
console.time(); | ||
f(500); | ||
let p = f(1500); | ||
deasync.sleep(1000); | ||
//msleep(1000); | ||
logWithTime(1000); | ||
deasync.await(p); | ||
console.timeEnd(); | ||
|
||
function logWithTime(...argv) | ||
{ | ||
console.log(`[${Date.now() - timstamp}]`, ...argv); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about errors what are falsy? for example
Promise.reject(0)
orPromise.reject(undefined)
.This still would no throw an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NotWearingPants I forgot that those rejections are technically possible. Indeed to cover that it would be better to use a
didThrow
variable instead.