perf: use setup-binary action to improve binary install performance (#…

…129) fix: #124
abcxyz · Sep 19, 2023 · 5755d9f · 5755d9f
1 parent e630e9e
commit 5755d9f
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 16 deletions.
diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml
@@ -27,10 +27,9 @@ on:
         type: 'string'
         required: true
       aod_cli_version:
-        description: 'The version of AOD CLI.'
+        description: 'The version of AOD CLI, without the "v" prefix, e.g. "0.1.2".'
         type: 'string'
-        default: 'latest'
-        required: false
+        required: true
       go_version:
         description: 'The version of Golang.'
         type: 'string'
@@ -109,8 +108,13 @@ jobs:
       - name: 'Set up Cloud SDK for tool request'
         if: '${{ hashFiles(''tool.yaml'') != '''' }}'
         uses: 'google-github-actions/setup-gcloud@e30db14379863a8c79331b04a9969f4c1e225e0b' # ratchet:google-github-actions/setup-gcloud@v1
-      - name: 'Install AOD CLI'
-        run: 'go install github.com/abcxyz/access-on-demand/cmd/aod@${{ inputs.aod_cli_version }}'
+      - name: 'Setup AOD'
+        uses: 'abcxyz/pkg/.github/actions/setup-binary@def8ffd12d32b2e8656152b1eea46017dc8f8eaa' # ratchet:abcxyz/pkg/.github/actions/setup-binary@v0.7.0
+        with:
+          download_url: 'https://github.com/abcxyz/access-on-demand/releases/download/v${{ inputs.aod_cli_version }}/aod_${{ inputs.aod_cli_version }}_linux_amd64.tar.gz'
+          install_path: '${{ runner.temp }}/.aod'
+          cache_key: '${{ runner.os }}_${{ runner.arch }}_aod_${{ inputs.aod_cli_version }}'
+          add_to_path: true
       - name: 'Handle tool cleanup'
         if: '${{ hashFiles(''tool.yaml'') != '''' }}'
         id: 'cleanup_tool'

diff --git a/.github/workflows/handle.yml b/.github/workflows/handle.yml
@@ -28,10 +28,9 @@ on:
         type: 'string'
         required: true
       aod_cli_version:
-        description: 'The version of AOD CLI.'
+        description: 'The version of AOD CLI, without the "v" prefix, e.g. "0.1.2".'
         type: 'string'
-        default: 'latest'
-        required: false
+        required: true
       go_version:
         description: 'The version of Golang.'
         type: 'string'
@@ -105,9 +104,14 @@ jobs:
       - name: 'Set up Cloud SDK'
         if: '${{ hashFiles(''tool.yaml'') != '''' }}'
         uses: 'google-github-actions/setup-gcloud@e30db14379863a8c79331b04a9969f4c1e225e0b' # ratchet:google-github-actions/setup-gcloud@v1
-      - name: 'Install AOD CLI'
+      - name: 'Setup AOD'
         if: '${{ hashFiles(''iam.yaml'', ''tool.yaml'') != '''' }}'
-        run: 'go install github.com/abcxyz/access-on-demand/cmd/aod@${{ inputs.aod_cli_version }}'
+        uses: 'abcxyz/pkg/.github/actions/setup-binary@def8ffd12d32b2e8656152b1eea46017dc8f8eaa' # ratchet:abcxyz/pkg/.github/actions/setup-binary@v0.7.0
+        with:
+          download_url: 'https://github.com/abcxyz/access-on-demand/releases/download/v${{ inputs.aod_cli_version }}/aod_${{ inputs.aod_cli_version }}_linux_amd64.tar.gz'
+          install_path: '${{ runner.temp }}/.aod'
+          cache_key: '${{ runner.os }}_${{ runner.arch }}_aod_${{ inputs.aod_cli_version }}'
+          add_to_path: true
       # Duration labels need to be prefixed with "duration-", an example is "duration-2h".
       - name: 'Get Duration From Label'
         if: '${{ hashFiles(''iam.yaml'') != '''' }}'

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -22,10 +22,9 @@ on:
   workflow_call:
     inputs:
       aod_cli_version:
-        description: 'The version of AOD CLI.'
+        description: 'The version of AOD CLI, without the "v" prefix, e.g. "0.1.2".'
         type: 'string'
-        default: 'latest'
-        required: false
+        required: true
       go_version:
         description: 'The version of Golang.'
         type: 'string'
@@ -48,8 +47,13 @@ jobs:
         uses: 'actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568' # ratchet:actions/setup-go@v3
         with:
           go-version: '${{ inputs.go_version }}'
-      - name: 'Install AOD CLI'
-        run: 'go install github.com/abcxyz/access-on-demand/cmd/aod@${{ inputs.aod_cli_version }}'
+      - name: 'Setup AOD'
+        uses: 'abcxyz/pkg/.github/actions/setup-binary@def8ffd12d32b2e8656152b1eea46017dc8f8eaa' # ratchet:abcxyz/pkg/.github/actions/setup-binary@v0.7.0
+        with:
+          download_url: 'https://github.com/abcxyz/access-on-demand/releases/download/v${{ inputs.aod_cli_version }}/aod_${{ inputs.aod_cli_version }}_linux_amd64.tar.gz'
+          install_path: '${{ runner.temp }}/.aod'
+          cache_key: '${{ runner.os }}_${{ runner.arch }}_aod_${{ inputs.aod_cli_version }}'
+          add_to_path: true
       # IAM request will not be validated when iam.yaml file does not exist,
       # tool request will be not validated when tool.yaml file does not exist.
       - name: 'Validate AOD Request'

diff --git a/docs/cli.md b/docs/cli.md
@@ -8,7 +8,7 @@ as a tool proxy.
 ## Installation
 
 ```sh
-go install github.com/abcxyz/access-on-demand/cmd/aod
+go install github.com/abcxyz/access-on-demand/cmd/aod@latest
 ```
 
 ## Usage