Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use pr updated_at for breakglass #156

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: use pr updated_at for breakglass #156

merged 1 commit into from
Apr 17, 2024

Conversation

verbanicm
Copy link
Contributor

@verbanicm verbanicm commented Apr 17, 2024 •
edited
Loading

  • Review submitted_at is null if this is for a breakglass label. Use pull_request updated_at instead.
  • Restrict AOD note to opened only, this should prevent duplicate comments for the base AOD note

@verbanicm verbanicm requested a review from a team as a code owner April 17, 2024 01:43
@verbanicm verbanicm enabled auto-merge (squash) April 17, 2024 01:43
@verbanicm verbanicm merged commit 79e476b into main Apr 17, 2024
2 checks passed
@verbanicm verbanicm deleted the verbanicm/fix branch April 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@chloechien chloechien Awaiting requested review from chloechien chloechien is a code owner automatically assigned from abcxyz/infrastructure-team

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verbanicm @sethvargo