Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only handles IAM PR with required approval #63

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

sqin2019
Copy link
Contributor

Fixes 57, to use this change, aod-template needs to add job permission pull-requests: 'read'

@sqin2019 sqin2019 requested a review from a team as a code owner July 11, 2023 20:25
@sqin2019 sqin2019 requested review from chloechien, verbanicm and yolocs and removed request for chloechien and verbanicm July 11, 2023 20:25
@sqin2019 sqin2019 marked this pull request as draft July 11, 2023 22:51
@sqin2019
Copy link
Contributor Author

Hold until we explore the alternative flow.

@yolocs
Copy link
Contributor

yolocs commented Jul 12, 2023

Should we punt this until we get clarity about whether we can do the merge flow?

@sqin2019 sqin2019 marked this pull request as ready for review July 12, 2023 18:32
Copy link
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

.github/workflows/handle.yml Outdated Show resolved Hide resolved
.github/workflows/handle.yml Outdated Show resolved Hide resolved
.github/workflows/handle.yml Show resolved Hide resolved
@sqin2019 sqin2019 merged commit b84b14e into main Jul 12, 2023
@sqin2019 sqin2019 deleted the sqin2019/issue57 branch July 12, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants