Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: note workflow - remove incorrect and unecessary condition #69

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

sqin2019
Copy link
Contributor

@sqin2019 sqin2019 commented Jul 14, 2023

for this condition to work need to checkout the triggering branch. We can add this condition in the triggering workflow instead

on:
  pull_request:
    types:
      - 'opened'
    paths:
      - 'iam.yaml'

@sqin2019 sqin2019 requested a review from a team as a code owner July 14, 2023 19:53
@sqin2019 sqin2019 requested review from pjh, lock14 and yolocs July 14, 2023 19:53
@sqin2019 sqin2019 enabled auto-merge (squash) July 14, 2023 19:54
Copy link
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part is incorrect? It probably won't hurt to have it?

@sqin2019 sqin2019 merged commit 41d5b58 into main Jul 14, 2023
@sqin2019 sqin2019 deleted the sqin/fix branch July 14, 2023 20:01
@sqin2019
Copy link
Contributor Author

Which part is incorrect? It probably won't hurt to have it?

it won't be able to search the files in the pull request unless it checkouts the triggering branch, which is a annoying/time-consuming step, so I figured why not remove it and it could be easily addressed in the calling workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants