-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: leech pipeline implementation #56
Conversation
fbf39dd
to
dcc191b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about making this a subcommand instead of a new binary?
I'm not sure how this would work with the beam runner. I'll see if I can make it work if you think it is the correct approach. I started there and pivoted away when I switch to Dataflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code lgtm but I wonder if we are able to add some unit test of the pipeline part?
Yes. I'm working on tests today. |
990aefd
to
2b178c4
Compare
6bea3e5
to
8c67e2c
Compare
Initial Dataflow pipeline implementation to ingest logs from GitHub into GCS.
Initial Dataflow pipeline implementation to ingest logs from GitHub into GCS.
There are a few open TODOs and outside of building the container image there is no way to deploy this yet - will get those in a follow up.