Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: leech pipeline implementation #56

Merged
merged 5 commits into from
May 18, 2023
Merged

feat: leech pipeline implementation #56

merged 5 commits into from
May 18, 2023

Conversation

bradegler
Copy link
Contributor

Initial Dataflow pipeline implementation to ingest logs from GitHub into GCS.

There are a few open TODOs and outside of building the container image there is no way to deploy this yet - will get those in a follow up.

@bradegler bradegler requested a review from a team as a code owner May 15, 2023 20:55
@bradegler bradegler requested review from shankiyani, capri-xiyue, sethvargo, verbanicm and yolocs and removed request for shankiyani and capri-xiyue May 15, 2023 20:55
Copy link
Contributor

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this a subcommand instead of a new binary?

pkg/leech/pipeline.go Show resolved Hide resolved
pkg/leech/pipeline.go Outdated Show resolved Hide resolved
pkg/leech/pipeline.go Outdated Show resolved Hide resolved
pipeline/leech/main.go Outdated Show resolved Hide resolved
pipeline/leech/main.go Outdated Show resolved Hide resolved
pkg/leech/config.go Outdated Show resolved Hide resolved
pkg/leech/pipeline.go Outdated Show resolved Hide resolved
pkg/leech/pipeline.go Outdated Show resolved Hide resolved
@bradegler
Copy link
Contributor Author

What do you think about making this a subcommand instead of a new binary?

I'm not sure how this would work with the beam runner. I'll see if I can make it work if you think it is the correct approach. I started there and pivoted away when I switch to Dataflow.

Copy link
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code lgtm but I wonder if we are able to add some unit test of the pipeline part?

pkg/leech/config.go Show resolved Hide resolved
pkg/leech/pipeline.go Show resolved Hide resolved
pkg/leech/pipeline.go Show resolved Hide resolved
@bradegler
Copy link
Contributor Author

The code lgtm but I wonder if we are able to add some unit test of the pipeline part?

Yes. I'm working on tests today.

@bradegler bradegler force-pushed the bradegler/sponge branch 2 times, most recently from 990aefd to 2b178c4 Compare May 18, 2023 15:28
pkg/leech/pipeline_test.go Outdated Show resolved Hide resolved
@bradegler bradegler enabled auto-merge (squash) May 18, 2023 17:43
@bradegler bradegler merged commit 0bee6c5 into main May 18, 2023
@bradegler bradegler deleted the bradegler/sponge branch May 18, 2023 17:51
verbanicm pushed a commit that referenced this pull request Jun 13, 2023
Initial Dataflow pipeline implementation to ingest logs from GitHub into GCS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants