fix: release docker tag (#206)

* fix: release docker tag * alter
abcxyz · Mar 8, 2023 · cff62ec · cff62ec
1 parent 82f0e7e
commit cff62ec
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -8,7 +8,6 @@ env:
   CONTAINER_REGISTRY: 'us-docker.pkg.dev/abcxyz-artifacts/docker-images'
   WIF_PROVIDER: 'projects/1096923323432/locations/global/workloadIdentityPools/github-pool-fd98/providers/github-provider'
   WIF_SERVICE_ACCOUNT: 'jvs-fd98-ci-sa@jvs-ci-test.iam.gserviceaccount.com'
-  DOCKER_TAG: '${{ github.ref_name }}'
   DEV_PROJECT_ID: 'jvs-dev-2c14'
   DEV_REGION: 'us-central1'
   DEV_API_SERVICE_NAME: 'jvs-api-99cd'
@@ -122,22 +121,26 @@ jobs:
         service_account: '${{ env.WIF_SERVICE_ACCOUNT }}'
     - name: 'Deploy Cloud Run services'
       run: |-
+        # Image tags are without 'v' prefix.
+        DOCKER_TAG="${{ github.ref_name }}"
+        DOCKER_TAG=${DOCKER_TAG#v}"
+
         gcloud run services update ${{ env.DEV_API_SERVICE_NAME }} \
           --project="${{ env.DEV_PROJECT_ID }}" \
           --region="${{ env.DEV_REGION }}" \
-          --image="${{ env.CONTAINER_REGISTRY }}/jvs-justification:${{ env.DOCKER_TAG }}-amd64"
+          --image="${{ env.CONTAINER_REGISTRY }}/jvs-justification:${DOCKER_TAG}-amd64"
 
         gcloud run services update ${{ env.DEV_UI_SERVICE_NAME }} \
           --project="${{ env.DEV_PROJECT_ID }}" \
           --region="${{ env.DEV_REGION }}" \
-          --image="${{ env.CONTAINER_REGISTRY }}/jvs-ui:${{ env.DOCKER_TAG }}-amd64"
+          --image="${{ env.CONTAINER_REGISTRY }}/jvs-ui:${DOCKER_TAG}-amd64"
 
         gcloud run services update ${{ env.DEV_CERT_ROTATOR_SERVICE_NAME }} \
           --project="${{ env.DEV_PROJECT_ID }}" \
           --region="${{ env.DEV_REGION }}" \
-          --image="${{ env.CONTAINER_REGISTRY }}/jvs-cert-rotation:${{ env.DOCKER_TAG }}-amd64"
+          --image="${{ env.CONTAINER_REGISTRY }}/jvs-cert-rotation:${DOCKER_TAG}-amd64"
 
         gcloud run services update ${{ env.DEV_PUBLIC_KEY_SERVICE_NAME }} \
           --project="${{ env.DEV_PROJECT_ID }}" \
           --region="${{ env.DEV_REGION }}" \
-          --image="${{ env.CONTAINER_REGISTRY }}/jvs-public-key:${{ env.DOCKER_TAG }}-amd64"
+          --image="${{ env.CONTAINER_REGISTRY }}/jvs-public-key:${DOCKER_TAG}-amd64"