feat: Add scaffolding as well as implementation for rotation_handler #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolocs
reviewed
Apr 15, 2022
sethvargo
requested changes
Apr 15, 2022
| // Example: | ||
| // `projects/*/locations/*/keyRings/*/cryptoKeys/*/cryptoKeyVersions/*` | ||
| // -> `projects/*/locations/*/keyRings/*/cryptoKeys/*` | ||
| func getKeyNameFromVersion(keyVersionName string) (string, error) { |
There was a problem hiding this comment.
There should be proto helpers for this already I think?
There was a problem hiding this comment.
i didn't see anything. https://pkg.go.dev/google.golang.org/genproto/googleapis/cloud/kms/v1#pkg-index
yolocs
requested changes
Apr 15, 2022
mikehelmick
reviewed
Apr 18, 2022
sethvargo
reviewed
Apr 18, 2022
This was referenced Apr 18, 2022
Closed
raserva
requested review from
a team,
crwilcox and
myurtoglu
and removed request for
a team
mikehelmick
reviewed
Apr 18, 2022
crwilcox
reviewed
Apr 18, 2022
apis/v1alpha1/crypto_config_test.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1alpha1 |
There was a problem hiding this comment.
it seems odd to me to include an empty test and that this could give a false sense that we are testing?
There was a problem hiding this comment.
I put it here in order to make it clear that this is intentionally TODO, as if there was no test file, it could just be an omission.
yolocs
reviewed
Apr 18, 2022
| } | ||
| defer kmsClient.Close() | ||
|
|
||
| // TODO: Set up server with mux. https://github.com/abcxyz/jvs/issues/8 |
There was a problem hiding this comment.
Tip: a simpler way is to "TODO(#8)"
|
test |
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
feat: Add scaffolding as well as implementation for rotation_handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is starting to get large, so i thought this was a good time to pause and set up a PR for what i had done so far. The config class is very much TODO at the moment, just the interface set up for the most part. The rotation_handler class is the meat of this PR