-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added jvs docs #114
Merged
Merged
docs: added jvs docs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capri-xiyue
requested review from
a team,
myurtoglu,
raserva and
yolocs
and removed request for
myurtoglu
August 23, 2022 19:57
yolocs
requested changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the disclaimer **JVS is not an official Google product.**
on every markdown file.
done |
yolocs
reviewed
Aug 26, 2022
yolocs
requested changes
Aug 31, 2022
yolocs
approved these changes
Aug 31, 2022
Co-authored-by: Chen Shou <cshou@google.com> Signed-off-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com>
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
* added jvs docs * fixed nits * fixed feedback * fixed feedback * fixed format * fixed format * fixed feedback * fixed feedback * fixed format * fixed link * Update docs/jvs-quick-setup.md Co-authored-by: Chen Shou <cshou@google.com> Signed-off-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com> Signed-off-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com> Co-authored-by: Chen Shou <cshou@google.com>
verbanicm
pushed a commit
that referenced
this pull request
Jun 14, 2023
* added jvs docs * fixed nits * fixed feedback * fixed feedback * fixed format * fixed format * fixed feedback * fixed feedback * fixed format * fixed link * Update docs/jvs-quick-setup.md Co-authored-by: Chen Shou <cshou@google.com> Signed-off-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com> Signed-off-by: capri-xiyue <52932582+capri-xiyue@users.noreply.github.com> Co-authored-by: Chen Shou <cshou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #113