feat: Add happy path integration test for Create Justification API #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raserva
changed the title
capri-xiyue
reviewed
Jun 10, 2022
capri-xiyue
reviewed
Jun 10, 2022
capri-xiyue
approved these changes
Jun 10, 2022
yolocs
approved these changes
Jun 13, 2022
Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
* change to creating keys in go rather than the terraform code during integ tests * changed to use env vars, and wait for version to be created * PR feedback * add the public key api terraform module, and a dev env setup module * starting jvs integ test * working integ test * small fixes * PR feedback * removed leftover file * Update pkg/test/integ/main_test.go Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * Update pkg/test/integ/main_test.go Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * minor fixes
verbanicm
pushed a commit
that referenced
this pull request
Jun 14, 2023
* change to creating keys in go rather than the terraform code during integ tests * changed to use env vars, and wait for version to be created * PR feedback * add the public key api terraform module, and a dev env setup module * starting jvs integ test * working integ test * small fixes * PR feedback * removed leftover file * Update pkg/test/integ/main_test.go Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * Update pkg/test/integ/main_test.go Co-authored-by: cshou <cshou@google.com> Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.