refactor: decouple terraform with integration test #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capri-xiyue
changed the title
capri-xiyue
changed the title
sethvargo
reviewed
Jun 27, 2022
raserva
reviewed
Jun 28, 2022
sethvargo
reviewed
Jun 28, 2022
capri-xiyue
commented
Jun 28, 2022
Fixed integration tests with Ryan's code change in https://github.com/abcxyz/jvs/pull/77/files#diff-d6d52d8832f033241a3648fd4b63767af8595a9dfc2498360a607f556862be13. Thank you @raserva for the fix! |
sethvargo
approved these changes
Jun 28, 2022
capri-xiyue
changed the title
raserva
approved these changes
Jun 28, 2022
yolocs
approved these changes
Jun 28, 2022
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
* decouple terraform with integration test * added comments * fixed service account * add project id and keyring in the caller * added validation * hardcode project id * changed to env variable * added testjvs back * fixed nits * hardcode service account * use env variable for service account * fixed integration test
verbanicm
pushed a commit
that referenced
this pull request
Jun 14, 2023
* decouple terraform with integration test * added comments * fixed service account * add project id and keyring in the caller * added validation * hardcode project id * changed to env variable * added testjvs back * fixed nits * hardcode service account * use env variable for service account * fixed integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decouple terraform with integration test