-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add necessary terraform setup for cert action api #80
Merged
+223
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raserva
changed the title
feat: Add necessary terraform setup for cert action api
** DRAFT, DON'T REVIEW** feat: Add necessary terraform setup for cert action api
Jun 30, 2022
raserva
changed the title
** DRAFT, DON'T REVIEW** feat: Add necessary terraform setup for cert action api
feat: Add necessary terraform setup for cert action api
Jun 30, 2022
raserva
requested review from
a team,
myurtoglu and
capri-xiyue
and removed request for
a team
June 30, 2022 20:02
myurtoglu
approved these changes
Jun 30, 2022
capri-xiyue
reviewed
Jun 30, 2022
capri-xiyue
approved these changes
Jun 30, 2022
Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
* added protos for new manual certificate action API * PR feedback * starting implementation of cert actions api * add necessary files for public sourcing * deleted other contribuing file * continuing implementation * more readmes * adding cert service to tf * finish cert service tf integration * PR feedback * Delete cert_action_server.go Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * Update main.go Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
verbanicm
pushed a commit
that referenced
this pull request
Jun 14, 2023
* added protos for new manual certificate action API * PR feedback * starting implementation of cert actions api * add necessary files for public sourcing * deleted other contribuing file * continuing implementation * more readmes * adding cert service to tf * finish cert service tf integration * PR feedback * Delete cert_action_server.go Signed-off-by: Ryan Serva <raserva@users.noreply.github.com> * Update main.go Signed-off-by: Ryan Serva <raserva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested in a newly created project