feat: remove env config in public key api and cert rotation api #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capri-xiyue
changed the title
capri-xiyue
changed the title
capri-xiyue
changed the title
sethvargo
reviewed
Jul 26, 2022
| if err != nil { | ||
| return fmt.Errorf("failed to load config: %w", err) | ||
| } | ||
|
|
||
| firestoreDoc, err := util.ParseFirestoreDocResource(cryptoCfg.FirestoreDocResourceName) |
There was a problem hiding this comment.
I don't know if we want this to be firestore per the doc just shared out. I'm worried about the coupling here.
There was a problem hiding this comment.
If we're unsure about firestore, maybe we should defer using firestore at all. It's not like we're missing functionality without it. Thoughts?
There was a problem hiding this comment.
Ok. I will revert the previous PR which already uses firestore #91 #97 and https://github.com/abcxyz/infra/pull/10
|
closed because we are deferring the firestore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove env config in public key api and cert rotation api