Skip to content

Commit

Permalink
Fix a NPE bug in grpc test (#295)
Browse files Browse the repository at this point in the history
These tests will NPE because they call a value on a pointer receiver that is nil if there's an error.
  • Loading branch information
sethvargo authored and yolocs committed Sep 15, 2022
1 parent 2416b07 commit 3e8294e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion integration/testrunner/grpcrunner/grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ func (g *GRPC) runFibonacciCheck(ctx context.Context, tb testing.TB) {
break
}
if err != nil {
tb.Errorf("Err while reading fibonacci stream: %v", err)
tb.Errorf("failed to read fibonacci stream: %v", err)
break
}
tb.Logf("Received value %v", place.Value)
}
Expand Down

0 comments on commit 3e8294e

Please sign in to comment.