Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pull and validate cli #435

Merged
merged 8 commits into from
Aug 11, 2023
Merged

feat: pull and validate cli #435

merged 8 commits into from
Aug 11, 2023

Conversation

sqin2019
Copy link
Contributor

@sqin2019 sqin2019 commented Aug 9, 2023 •
edited
Loading

part of #427

@sqin2019 sqin2019 requested a review from a team as a code owner August 9, 2023 20:42
@sqin2019 sqin2019 requested review from pjh, sailorlqh and yolocs and removed request for pjh August 9, 2023 20:42
sqin2019
sqin2019 commented Aug 9, 2023
View reviewed changes
pkg/cli/validate_pull.go Outdated Show resolved Hide resolved
sethvargo
sethvargo reviewed Aug 9, 2023
View reviewed changes
pkg/cli/root.go Outdated Show resolved Hide resolved
yolocs
yolocs reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've discussed offline, let's name the subcommand tail and add -validate flag to enable validation.

yolocs
yolocs reviewed Aug 10, 2023
View reviewed changes
pkg/cli/root_test.go Outdated Show resolved Hide resolved
yolocs
yolocs requested changes Aug 10, 2023
View reviewed changes
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
yolocs
yolocs reviewed Aug 10, 2023
View reviewed changes
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
sqin2019
sqin2019 commented Aug 11, 2023
View reviewed changes
pkg/cli/tail_test.go Outdated Show resolved Hide resolved
@sqin2019 sqin2019 requested a review from yolocs August 11, 2023 02:07
yolocs
yolocs requested changes Aug 11, 2023
View reviewed changes
pkg/cli/tail_test.go Show resolved Hide resolved
pkg/cli/tail.go Outdated Show resolved Hide resolved
@sqin2019 sqin2019 merged commit b190d19 into main Aug 11, 2023
@sqin2019 sqin2019 deleted the sqin/cli branch August 11, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvargo sethvargo sethvargo left review comments

@yolocs yolocs yolocs approved these changes

@sailorlqh sailorlqh Awaiting requested review from sailorlqh sailorlqh is a code owner automatically assigned from abcxyz/infrastructure-team

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sqin2019 @sethvargo @yolocs