Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add ISO 14496-30 WebVTT Box #170

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

monyone
Copy link
Contributor

@monyone monyone commented Jan 7, 2025

@sunfish-shogi

These boxes allows to marshal and unmarshal WebVTT boxes.

Sample WebVTT in isobmff file is below.
https://github.com/user-attachments/assets/2cc6806b-fa10-448d-af70-67c9f9dcef05

@sunfish-shogi
Copy link
Contributor

Thank you for PR!!

@sunfish-shogi sunfish-shogi merged commit 89fe2fe into abema:master Jan 8, 2025
9 checks passed
@sunfish-shogi
Copy link
Contributor

@monyone
Sorry, I overlooked an issue regarding the boxstring in the review.
14496-30 defines boxstring as a UTF-8 string without a leading character or null terminator.
I will try to fix it and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants