Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QuickTime style AudioSampleEntry and wave box #52

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

sunfish-shogi
Copy link
Contributor

relate to
#50
#7

@sunfish-shogi sunfish-shogi added the bug Something isn't working label Nov 14, 2020
@sunfish-shogi sunfish-shogi self-assigned this Nov 14, 2020
@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #52 (0991583) into master (55702ef) will increase coverage by 0.05%.
The diff coverage is 84.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   80.94%   81.00%   +0.05%     
==========================================
  Files          13       13              
  Lines        1543     1579      +36     
==========================================
+ Hits         1249     1279      +30     
- Misses        168      171       +3     
- Partials      126      129       +3     
Impacted Files Coverage Δ
box.go 73.91% <ø> (ø)
box_info.go 76.78% <ø> (ø)
extract.go 81.81% <50.00%> (-3.55%) ⬇️
read.go 56.47% <61.11%> (+2.30%) ⬆️
string.go 86.92% <83.33%> (+0.10%) ⬆️
marshaller.go 79.78% <94.73%> (+0.08%) ⬆️
box_types.go 91.22% <100.00%> (+0.29%) ⬆️
probe.go 61.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55702ef...0991583. Read the comment docs.

@sunfish-shogi sunfish-shogi added enhancement New feature or request and removed bug Something isn't working labels Nov 15, 2020
@sunfish-shogi sunfish-shogi changed the title Fix AudioSampleEntry for QuickTime Support QuickTime style AudioSampleEntry and wave box Nov 15, 2020
@sunfish-shogi sunfish-shogi merged commit 04634da into master Nov 15, 2020
@sunfish-shogi sunfish-shogi deleted the fix-qt-mp4a branch November 15, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants