Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linter #178

Merged
merged 1 commit into from
Nov 4, 2023
Merged

chore: fix linter #178

merged 1 commit into from
Nov 4, 2023

Conversation

abemedia
Copy link
Owner

@abemedia abemedia commented Nov 4, 2023

No description provided.

@abemedia abemedia enabled auto-merge (squash) November 4, 2023 14:44
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a2820f) 98.35% compared to head (b8ece60) 98.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          24       24           
  Lines         850      850           
=======================================
  Hits          836      836           
  Misses          9        9           
  Partials        5        5           
Files Coverage Δ
decoder/decode.go 100.00% <ø> (ø)
pool.go 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abemedia abemedia merged commit ad4d428 into master Nov 4, 2023
11 checks passed
@abemedia abemedia deleted the chore/fix-linter branch November 4, 2023 14:45
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Benchmark Results

.
goos: linux
goarch: amd64
pkg: github.com/abemedia/go-don
cpu: AMD EPYC 7763 64-Core Processor                
                         │   before    │               after                │
                         │   sec/op    │   sec/op     vs base               │
Handler/Request-4          263.2n ± 3%   268.8n ± 2%  +2.11% (p=0.011 n=10)
Handler/RequestPointer-4   260.8n ± 0%   260.6n ± 2%       ~ (p=0.697 n=10)
geomean                    262.0n        264.7n       +1.02%

                         │   before   │                after                │
                         │    B/op    │    B/op     vs base                 │
Handler/Request-4          24.00 ± 0%   24.00 ± 0%       ~ (p=1.000 n=10) ¹
Handler/RequestPointer-4   24.00 ± 0%   24.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                    24.00        24.00       +0.00%
¹ all samples are equal

                         │   before   │                after                │
                         │ allocs/op  │ allocs/op   vs base                 │
Handler/Request-4          1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
Handler/RequestPointer-4   1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                    1.000        1.000       +0.00%
¹ all samples are equal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant