Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt remix-themes for react-router-v7 #48

Closed
wants to merge 3 commits into from

Conversation

Moonnz
Copy link

@Moonnz Moonnz commented Dec 27, 2024

Summary

This pull request introduces a simple adaptation to support React Router v7.

Changes Made

  • Adjusted the code to ensure compatibility with React Router v7.

Notes

  • The application itself has not been updated or tested extensively with these changes. Further work may be required to ensure full compatibility.

Next Steps

  • Review the changes for correctness.
  • Consider testing the application thoroughly to identify any issues related to the migration.

@Moonnz
Copy link
Author

Moonnz commented Jan 9, 2025

Failed but unrelated to the code:

This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

@abereghici
Copy link
Owner

Thanks @Moonnz for this pull request! I noticed the unit tests are not working and I decided to refactor this package from scratch using the latest dependency versions. I created a new MR based on yours here : #49

Could you please review it when you have some time? Thanks!

@abereghici
Copy link
Owner

abereghici commented Jan 12, 2025

I will close this MR as we released already the react-router v7 support. Thanks @Moonnz for this MR, it was really helpful for package refactoring.

@abereghici abereghici closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants