Switch embed to llama_get_embeddings_seq #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamlemec thank you! Just so I understand, the sequence level embeddings are the ones that are pooled up to the end of the from the last processed batch? Also, I think the new function in |
abetlen
reviewed
Mar 9, 2024
|
Oh yeah, I didn't see you added it already! Yup, it's the pooled embeddings by sequence for the last batch. So for both mean pooling and cls (first token) it works, and for non-pooling it returns null. |
Co-authored-by: Andrei <abetlen@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to updates in ggml-org/llama.cpp#5796, sequence level embeddings are now output through a separate channel from token level embeddings, and they are accessed with
llama_get_embeddings_seq.