fix last tokens passing to sample_repetition_penalties function #1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: currently all previous tokens are passing to
llama_sample_repetition_penalties
function instead of lastpenalty_last_n
tokens.Description:
llama_sample_repetition_penalties
function expects lastpenalty_last_n
tokens. But it gets all previously generated tokens which leads to the algorithm not working correctly.As you can see in the code below it will use only first
penalty_last_n
tokens to createtoken_count
dict:This behavior is obviously incorrect which in our case led to the case where our model had a lot of answers with repetitions.
Also in this PR was fixed bug with possible buffer overflow that could cause to segfault in code above.