Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to read from stdin #322

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Add support to read from stdin #322

merged 3 commits into from
Oct 25, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 24, 2021

Description

Using - as file path is standard Unix to read from/to stdin/stdout instead of a file. The write command already supported -, but not the read command. This PR fixes this.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #322 (078a42b) into master (ea7dadc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   92.06%   92.08%   +0.01%     
==========================================
  Files          50       50              
  Lines        3945     3954       +9     
  Branches      520      521       +1     
==========================================
+ Hits         3632     3641       +9     
  Misses        209      209              
  Partials      104      104              
Impacted Files Coverage Δ
tests/test_files.py 100.00% <100.00%> (ø)
vpype/io.py 77.62% <100.00%> (ø)
vpype_cli/read.py 87.50% <100.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7dadc...078a42b. Read the comment docs.

@abey79 abey79 merged commit 48ce3a8 into master Oct 25, 2021
@abey79 abey79 deleted the feature-read-stdin branch October 25, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant