Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dependencies to dataclasses (from attrs) and tomli (from toml) #362

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Dec 29, 2021

Description

toml -> tomli
attirs -> dataclasses

  • updated deps versions

Fixes #353

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

Deps: attrs -> dataclasses
Updated deps versions
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #362 (8709d1e) into master (366cdd3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          50       50           
  Lines        3991     3992    +1     
  Branches      552      552           
=======================================
+ Hits         3686     3687    +1     
  Misses        203      203           
  Partials      102      102           
Impacted Files Coverage Δ
vpype/config.py 97.89% <100.00%> (+0.02%) ⬆️
vpype_cli/cli.py 74.56% <100.00%> (ø)
vpype_cli/layerops.py 97.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366cdd3...8709d1e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 8196552 into master Dec 29, 2021
@abey79 abey79 deleted the dep-remove-attrs branch December 29, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency: remplace toml by tomli
1 participant