Feature: expression substitution #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 93.54% 93.72% +0.18%
==========================================
Files 56 59 +3
Lines 4666 5135 +469
Branches 648 717 +69
==========================================
+ Hits 4365 4813 +448
- Misses 201 207 +6
- Partials 100 115 +15
Continue to review full report at Codecov.
|
abey79
force-pushed
the
feature-expressions
branch
3 times, most recently
from
9a594c1 to
d8b104d
Compare
Expression between `%` markers are now evaluated by asteval. - Fixed pycharm type error with CliRunner.execute() - Minor update to docstrings - Updated deps
- added `forfile` command - added `forlayer` command - added FileType and PathType (with prop/exp substitution) - added variables to `grid` and `repeat` - vp.Document: added option to copy metadata with `replace()` - `State`: renamed CM to temp_document() - `State`: added CM to set variables
- fixed tests - improved coverage
- quotes for path (windows fix?)
- added substitution to LayerType
- added `--no-fail` to read
- added glob and convert_{length, angle, page_size} to expr symbols
- disabled numpy from expr
- grid now sets page size
- fixed logging to print fully substituted arguments
- added args logging to @block_processor
- added example for interactive grid
- doc: renamed metadata section to properties
abey79
force-pushed
the
feature-expressions
branch
from
ffa53c2 to
270bb4c
Compare
- removed all useless `return state` from execute_pipeline & decorators - fixed bug with linesort not keeping metadata - multiple doc type & example fixes
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces expression substitution on most user input. Expressions are marked with
%characters and are a subset of the Python language. They are interpreted using theastevalpackage (see doc). See doc for the built-in symbols.New commands:
forfileforlayerevalMisc other changes:
readcommand now will not fail if the provided file doesn't exist and the--no-failparameter is usedgridnow sets page sizereadnow sets/update thevp_source/vp_sourcessystem props--no-failto readvp_sourcesupdate invp.DocumentFixes #392
Fixes #381
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)