Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plotters #474

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Add new plotters #474

merged 2 commits into from
Jun 1, 2022

Conversation

ithinkido
Copy link
Contributor

@ithinkido ithinkido commented May 8, 2022

Description

Add the following HPGL plotter configs - HP7550, Roland DXY 1xxx and Sketchmate.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • [ x ] CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #474 (ec75633) into master (faad5b2) will not change coverage.
The diff coverage is n/a.

❗ Current head ec75633 differs from pull request most recent head df21281. Consider uploading reports for the commit df21281 to get more accurate results

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files          60       60           
  Lines        5396     5396           
  Branches      786      786           
=======================================
  Hits         5093     5093           
  Misses        185      185           
  Partials      118      118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faad5b2...df21281. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abey79 abey79 merged commit e5419d7 into abey79:master Jun 1, 2022
@abey79
Copy link
Owner

abey79 commented Jun 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants