Change HexGrid::spacing()
to accept a single scalar and maintain hexagonal grid
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the hexagons placed within hexagon grid when setting spacing. Previous version placed them in rectangular grid.
Note that it does change the argument type for spacing function arguments from
[f64; 2]
tof64
it is still possible to set separate spacing for vertical and horizontal spacing usinghorizontal_spacing
andvertical_spacing
functions.If you want to maintain old function signature I don't mind changing using different approach.
[f64; 2]
argument, but multiply one of them by cos(30) -> it may be slightly confusing actual vertical/horizontal spacing differs from argument by than nontrivial multiplier, also havinggrid.vertical_spacing(x).horizontal_spacing(y)
different behavior thangrid.spacing([x, y])
can be unexpected