Make server page graph coloring consistent with scoring #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this changed
The scoring system currently has four "ranges" depending on the time offset between the monitored server and the monitor:
The colouring scheme in the graphs of the management sites had three "ranges":
My suggestion is to unify both systems. This increases transparency for pool operators and users. The graph already is the direct feedback what the monitoring system thinks about the server in terms of current reputation. Adding in the colouring scheme adds the layer of how the reputation is currently changing.
To keep the current traffic light scheme with red-yellow-green, I've decided to map everything in the negative point range to "red" since this indicates that the server will lose points and drop out of the NTP Pool eventually. The yellow range is adjusted to the slow gain range where the server is generally considered viable, but gets a penalty for inaccuracy. Indicating this with yellow should also give the server operator the feedback that the accuracy of the server should be improved. The range where the server gets the full score is indicated in green.
What was changed
I simply edited the threshold that determine the colors.
Impact
Expected advantages have been outlined above.
Since this is a purely visual change, I do not expect any negative side effects.
I look forward to constructive feedback and reviews.