Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor main() #9

Closed
wants to merge 3 commits into from
Closed

refactor main() #9

wants to merge 3 commits into from

Conversation

slaterslater
Copy link

@slaterslater slaterslater commented Oct 3, 2020 •
edited
Loading

Fixes #8

  • refactored main() into smaller functions
  • added a print_status() function to reduce repetition of long print statements
  • get_urls() only appends to urls list if string starts with 'http'

@abhaseen
Copy link
Owner

abhaseen commented Oct 5, 2020 •
edited
Loading

Issue was partially solved in a prior pull request made to this one. (See Release 0.4 - latest release). Additionally, doesn't meet latest cross-platform implementations for displaying colors. Parsing fix and refactoring was done well, needs to meet latest version though.

@abhaseen abhaseen closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring the main() function
2 participants
@slaterslater @abhaseen