Skip to content

Commit

Permalink
fix: resolve ESLint config from appPath (facebook#9683)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrmckeb authored and abhiisheek committed May 24, 2023
1 parent f050436 commit 14310fc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/eslint-config-react-app/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ module.exports = {
rules: {
'react/jsx-uses-react': 'warn',
'react/jsx-uses-vars': 'warn',
'react/react-in-jsx-scope': 'error',
},
};
1 change: 0 additions & 1 deletion packages/eslint-config-react-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ module.exports = {
'react/no-direct-mutation-state': 'warn',
'react/no-is-mounted': 'warn',
'react/no-typos': 'error',
'react/react-in-jsx-scope': 'error',
'react/require-render-return': 'error',
'react/style-prop-object': 'warn',

Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ module.exports = function (webpackEnv) {
{
options: {
cache: true,
cwd: paths.appPath,
formatter: require.resolve('react-dev-utils/eslintFormatter'),
eslintPath: require.resolve('eslint'),
resolvePluginsRelativeTo: __dirname,
Expand Down

0 comments on commit 14310fc

Please sign in to comment.