Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domain setting #32

Open
MironChen opened this issue May 5, 2020 · 6 comments
Open

Custom Domain setting #32

MironChen opened this issue May 5, 2020 · 6 comments
Labels
impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: awaiting author response Additional information has been requested from the author type: question or discussion Issue discussing or asking a question type: upstream Issues outside of this project's control, caused by dependencies

Comments

@MironChen
Copy link

Hi, it's me again.

According to your deploy.sh , I can only deploy to username.github.io . However, as long as I deploy for the next time, even though I have set a custom domain in Github, it will insist on username.github.io .

I wonder what should I change.

Thanks a lot.

@pavlenex
Copy link

Here's what I tried and it worked for me.
Instead github pages, yourdomain.github.io I created a regular repostirory where I deployed everything. Then I simply connected to Netifly where I configured my DNS and it worked. I am checking if building process is automatic and if I have to do something more.

@pavlenex
Copy link

Yup can confirm netlify + this works amazing with custom domain and there's no configuration needed regarding building, it's just a few clicks defaults.

@abhijithvijayan
Copy link
Owner

abhijithvijayan commented May 30, 2020

Yeah, I have migrated my projects from GitHub pages to Netlify some time ago. Never looked back.

The whole aim of the project is to deploy the dynamic blog as a static one and host without charges(with custom domain and other features).

Like @pavlenex said, Use Nelify to deploy the static page.

  • Create a regular repo(with CLI for easiness npx create-remote-repo blog)
  • Deploy the content to the repository
  • Connect Netlify to the repository
  • Deploy with Netlify
  • Setup custom domain if needed
  • Voila :)

@abhijithvijayan abhijithvijayan added impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: awaiting author response Additional information has been requested from the author type: question or discussion Issue discussing or asking a question type: upstream Issues outside of this project's control, caused by dependencies labels May 30, 2020
@abhijithvijayan
Copy link
Owner

With netlify I see this error
Deployed filenames cannot contain # or ? characters for the 'assets/built/custom.css?v=536fdc0854.css' entry

@pavlenex Did you have any issues while building with Netlify?

@pavlenex
Copy link

pavlenex commented May 30, 2020

Hey @abhijithvijayan It didn't. It worked well for me. Worked exactly as you described above. Unfortunately I'm not sure how I can help besides that, quite new to all this. Let me know if there's something I can do to help reproduce though.

@abhijithvijayan
Copy link
Owner

Never mind. It's the netlify that stopping the build process.

?version query param is added for cache busting.

Probably have to figure out another way to make it work with Netlify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: awaiting author response Additional information has been requested from the author type: question or discussion Issue discussing or asking a question type: upstream Issues outside of this project's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

3 participants