Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish a GitHub Release after tagging #782

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Publish a GitHub Release after tagging #782

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54a783
Publish a GitHub Release after tagging
webknjaz Nov 23, 2021
bb7953f
Merge branch 'develop' into maintenance/gha-gh-release
abhinavsingh Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/test-library.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,4 +772,38 @@ jobs:
to the just published release back to GitHub
run: >-
git push --atomic origin '${{ needs.pre-setup.outputs.git-tag }}'

publish-github-release:
name: >-
Publish a GitHub Release for
${{ needs.pre-setup.outputs.git-tag }}
needs:
- post-release-repo-update
- pre-setup # transitive, for accessing settings
runs-on: Ubuntu-latest

permissions:
contents: write

steps:
- name: Download all the dists
uses: actions/download-artifact@v2
with:
name: python-package-distributions
path: dist/

- name: >-
Publish a GitHub Release for
${{ needs.pre-setup.outputs.git-tag }}
uses: softprops/action-gh-release@v1
with:
# body/body_path: # FIXME: Use once Towncrier is integrated.
discussion_category_name: Announcements
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavsingh this is why I asked you to create the discussions category. It'll auto-create announcement topics on release so that there's a centralized place for people to comment on a given version post-release.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I haven't checked on the release flows yet . Good to see. Was thinking of release this week, but might only be able to make one over the weekend. Will keep ya updated or anyways it will post to announcements :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavsingh if you want, we could plan to do this via a video call together. LMK if you'd want to do this and the TZ you're currently in.

fail_on_unmatched_files: true
files: |
dist/${{ needs.pre-setup.outputs.sdist-artifact-name }}
dist/${{ needs.pre-setup.outputs.wheel-artifact-name }}
name: ${{ needs.pre-setup.outputs.git-tag }}
tag_name: ${{ needs.pre-setup.outputs.git-tag }}
target_commitish: ${{ github.event.inputs.release-commitish }}
...