Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModifyWebSocketResponsePlugin #914

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

abhinavsingh
Copy link
Owner

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Dec 27, 2021
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Attention: Patch coverage is 61.70213% with 18 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (d4449b8) to head (8ac4cac).
Report is 270 commits behind head on develop.

Files Patch % Lines
proxy/http/websocket/frame.py 66.66% 6 Missing and 5 partials ⚠️
proxy/plugin/modify_websocket_response.py 45.45% 6 Missing ⚠️
proxy/plugin/web_server_route.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #914      +/-   ##
===========================================
- Coverage    87.80%   87.64%   -0.16%     
===========================================
  Files          131      132       +1     
  Lines         5903     5917      +14     
  Branches       590      593       +3     
===========================================
+ Hits          5183     5186       +3     
- Misses         619      631      +12     
+ Partials       101      100       -1     
Flag Coverage Δ
pytest 87.47% <61.70%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavsingh abhinavsingh marked this pull request as draft January 17, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebSocketFrame] Exception when building frames with very large payloads
1 participant