-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify via email of message transmission errors #44
base: master
Are you sure you want to change the base?
Conversation
Added function to notify of errors
Notify of failure to send
Notify of error on message receive
Notify of errors processing message
Fixed missing ')'
fixed blank line contains whitespace
Fixed code formatting
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.56% 97.12% -0.45%
==========================================
Files 11 11
Lines 576 591 +15
==========================================
+ Hits 562 574 +12
- Misses 14 17 +3
Continue to review full report at Codecov.
|
@kenyonit @abhishek-ram I generally would subscribe to the idea, that an email could be sent on failed message sending. From quick look at this code, I do not see to whom this should be sent. I suppose the email as defined in the Organization? Any thoughts on this @abhishek-ram ? |
Hi @abhishek-ram, |
@abhishek-ram, |
Should we do logger error in all these places so that devs can make use of https://docs.djangoproject.com/en/5.0/ref/logging/#django.utils.log.AdminEmailHandler to send emails? |
@abhishek-ram No we shouldn't of course. I didn't know what you were writing about. You know, I'm not django expert. So many thank for your tips |
Send an email to managers for any message transmission errors