minor feedback (cadence-workflow#5776)

Just making the logs both slightly more defensive and returning early where possible.
abhishekj720 · Mar 11, 2024 · 646ac32 · 646ac32
1 parent 9bd6ca2
commit 646ac32
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/service/history/execution/mutable_state_builder.go b/service/history/execution/mutable_state_builder.go
@@ -4812,30 +4812,39 @@ func (e *mutableStateBuilder) unixNanoToTime(
 }
 
 func (e *mutableStateBuilder) logInfo(msg string, tags ...tag.Tag) {
-	if e != nil && e.executionInfo != nil {
+	if e != nil {
+		return
+	}
+	if e.executionInfo != nil {
 		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
 		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
 		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-		e.logger.Info(msg, tags...)
 	}
+	e.logger.Info(msg, tags...)
 }
 
 func (e *mutableStateBuilder) logWarn(msg string, tags ...tag.Tag) {
-	if e != nil && e.executionInfo != nil {
+	if e != nil {
+		return
+	}
+	if e.executionInfo != nil {
 		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
 		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
 		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-		e.logger.Warn(msg, tags...)
 	}
+	e.logger.Warn(msg, tags...)
 }
 
 func (e *mutableStateBuilder) logError(msg string, tags ...tag.Tag) {
-	if e != nil && e.executionInfo != nil {
+	if e != nil {
+		return
+	}
+	if e.executionInfo != nil {
 		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
 		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
 		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-		e.logger.Error(msg, tags...)
 	}
+	e.logger.Error(msg, tags...)
 }
 
 func (e *mutableStateBuilder) logDataInconsistency() {