Skip to content

Commit

Permalink
Split historyEngine.go into small files (cadence-workflow#5972)
Browse files Browse the repository at this point in the history
  • Loading branch information
taylanisikdemir authored and abhishekj720 committed May 7, 2024
1 parent a5d3bcb commit 7f82bb5
Show file tree
Hide file tree
Showing 35 changed files with 4,703 additions and 3,824 deletions.
2 changes: 1 addition & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ coverage:
if_ci_failed: ignore # require the CI to pass before setting the status
patch:
default:
target: 85% # specify the target coverage for each commit status
target: 0% # specify the target coverage for each commit status
# option: "auto" (compare against parent commit or pull request base)
# option: "X%" a static target percentage to hit
threshold: 0% # allow the coverage drop by x% before marking as failure
Expand Down
50 changes: 50 additions & 0 deletions service/history/engine/engineimpl/cross_cluster_operations.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Copyright (c) 2017-2021 Uber Technologies, Inc.
// Portions of the Software are attributed to Copyright (c) 2021 Temporal Technologies Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

package engineimpl

import (
"context"

"github.com/uber/cadence/common/types"
"github.com/uber/cadence/service/history/queue"
)

func (e *historyEngineImpl) GetCrossClusterTasks(
ctx context.Context,
targetCluster string,
) ([]*types.CrossClusterTaskRequest, error) {
actionResult, err := e.crossClusterProcessor.HandleAction(ctx, targetCluster, queue.NewGetTasksAction())
if err != nil {
return nil, err
}

return actionResult.GetTasksResult.TaskRequests, nil
}

func (e *historyEngineImpl) RespondCrossClusterTasksCompleted(
ctx context.Context,
targetCluster string,
responses []*types.CrossClusterTaskResponse,
) error {
_, err := e.crossClusterProcessor.HandleAction(ctx, targetCluster, queue.NewUpdateTasksAction(responses))
return err
}
87 changes: 87 additions & 0 deletions service/history/engine/engineimpl/describe_mutable_state.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
// Copyright (c) 2017-2021 Uber Technologies, Inc.
// Portions of the Software are attributed to Copyright (c) 2021 Temporal Technologies Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

package engineimpl

import (
"context"
"encoding/json"

"github.com/uber/cadence/common"
"github.com/uber/cadence/common/types"
"github.com/uber/cadence/service/history/execution"
)

func (e *historyEngineImpl) DescribeMutableState(
ctx context.Context,
request *types.DescribeMutableStateRequest,
) (response *types.DescribeMutableStateResponse, retError error) {

if err := common.ValidateDomainUUID(request.DomainUUID); err != nil {
return nil, err
}

domainID := request.DomainUUID
execution := types.WorkflowExecution{
WorkflowID: request.Execution.WorkflowID,
RunID: request.Execution.RunID,
}

cacheCtx, dbCtx, release, cacheHit, err := e.executionCache.GetAndCreateWorkflowExecution(
ctx, domainID, execution,
)
if err != nil {
return nil, err
}
defer func() { release(retError) }()

response = &types.DescribeMutableStateResponse{}

if cacheHit {
if msb := cacheCtx.GetWorkflowExecution(); msb != nil {
response.MutableStateInCache, err = e.toMutableStateJSON(msb)
if err != nil {
return nil, err
}
}
}

msb, err := dbCtx.LoadWorkflowExecution(ctx)
if err != nil {
return nil, err
}
response.MutableStateInDatabase, err = e.toMutableStateJSON(msb)
if err != nil {
return nil, err
}

return response, nil
}

func (e *historyEngineImpl) toMutableStateJSON(msb execution.MutableState) (string, error) {
ms := msb.CopyToPersistence()

jsonBytes, err := json.Marshal(ms)
if err != nil {
return "", err
}
return string(jsonBytes), nil
}
76 changes: 76 additions & 0 deletions service/history/engine/engineimpl/describe_queues.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
// Copyright (c) 2017-2021 Uber Technologies, Inc.
// Portions of the Software are attributed to Copyright (c) 2021 Temporal Technologies Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

package engineimpl

import (
"context"
"fmt"

"github.com/uber/cadence/common/types"
"github.com/uber/cadence/service/history/queue"
)

func (e *historyEngineImpl) DescribeTransferQueue(
ctx context.Context,
clusterName string,
) (*types.DescribeQueueResponse, error) {
return e.describeQueue(ctx, e.txProcessor, clusterName)
}

func (e *historyEngineImpl) DescribeTimerQueue(
ctx context.Context,
clusterName string,
) (*types.DescribeQueueResponse, error) {
return e.describeQueue(ctx, e.timerProcessor, clusterName)
}

func (e *historyEngineImpl) DescribeCrossClusterQueue(
ctx context.Context,
clusterName string,
) (*types.DescribeQueueResponse, error) {
return e.describeQueue(ctx, e.crossClusterProcessor, clusterName)
}

func (e *historyEngineImpl) describeQueue(
ctx context.Context,
queueProcessor queue.Processor,
clusterName string,
) (*types.DescribeQueueResponse, error) {
resp, err := queueProcessor.HandleAction(ctx, clusterName, queue.NewGetStateAction())
if err != nil {
return nil, err
}

serializedStates := make([]string, 0, len(resp.GetStateActionResult.States))
for _, state := range resp.GetStateActionResult.States {
serializedStates = append(serializedStates, e.serializeQueueState(state))
}
return &types.DescribeQueueResponse{
ProcessingQueueStates: serializedStates,
}, nil
}

func (e *historyEngineImpl) serializeQueueState(
state queue.ProcessingQueueState,
) string {
return fmt.Sprintf("%v", state)
}
Loading

0 comments on commit 7f82bb5

Please sign in to comment.