Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viral Shorts Video Analysis #627

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Viral Shorts Video Analysis #627

merged 9 commits into from
Jun 7, 2024

Conversation

HarshRaj29004
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Viral Shorts Video Analysis

  • Info about the related issue (Aim of the project) : The aim of this project is to analyze the viral videos based on the given dataset.
  • Name: Harsh Raj
  • GitHub ID:
  • Idenitfy yourself: SSOC-24 contributor

Closes: #509

Describe the add-ons or changes you've made 📃

  • Creates an all sort of analyzed visuals, perform preprocessing in dataset and finally made a model.

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jun 4, 2024

Our team will soon review your PR. Thanks @HarshRaj29004 :)

@HarshRaj29004
Copy link
Contributor Author

Now i have done all sort of changes
it will be working now

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove the bfg.jar file.
  2. Sub folder names should be like, Models, Images, Dataset.
  3. It's not required.txt, it should be requirements.txt.

@HarshRaj29004

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 5, 2024
@abhisheks008
Copy link
Owner

Please update the sub folder names, it should be Dataset, Images like this.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HarshRaj29004 visual plots are not showing after you made your changes.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @HarshRaj29004

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 7, 2024
@abhisheks008 abhisheks008 merged commit edf86ef into abhisheks008:main Jun 7, 2024
@abhisheks008
Copy link
Owner

Hi @HarshRaj29004 please share your email address for further communications.

@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 7, 2024
@HarshRaj29004
Copy link
Contributor Author

hr768381@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viral Shorts Videos Analysis
2 participants