Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make persistence optional with --save-config flag #1123

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

abiosoft
Copy link
Owner

@abiosoft abiosoft commented Aug 25, 2024

This introduces a new --save-config flag which defaults to true.

To prevent Colima from overriding configuration settings, --save-config=false should be specified for colima start.

As an alternative option, COLIMA_SAVE_CONFIG=0 environment variable can be set.

Fixes #613.

Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
@abiosoft abiosoft merged commit c2595d4 into main Aug 25, 2024
11 checks passed
@abiosoft abiosoft deleted the optional-config-override branch August 25, 2024 09:29
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 28, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [abiosoft/colima](https://github.com/abiosoft/colima) | patch | `v0.7.3` -> `v0.7.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>abiosoft/colima (abiosoft/colima)</summary>

### [`v0.7.5`](https://github.com/abiosoft/colima/releases/tag/v0.7.5)

[Compare Source](abiosoft/colima@v0.7.4...v0.7.5)

#### Highlights

This is an hotfix release to address a regression in networking for Incus runtime.

#### Commits

-   incus: utilise macvlan network for multiple IP addresses by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1124

**Full Changelog**: abiosoft/colima@v0.7.4...v0.7.5

### [`v0.7.4`](https://github.com/abiosoft/colima/releases/tag/v0.7.4)

[Compare Source](abiosoft/colima@v0.7.3...v0.7.4)

#### Highlights

This is an incremental update with bug fixes.

#### Updates

-   Colima can now be prevented from overwriting config file on startup by specifying `--save-config=false` or setting `COLIMA_SAVE_CONFIG=0`.
-   Warning error would no longer be displayed on startup for users that install Colima with [aqua](https://aquaproj.github.io/).
-   An extra warning is now displayed on `colima delete` to further ascertain the user's intended action.

#### Commits

-   docker: remove cert cache directory before copying host certs by [@&#8203;soedar](https://github.com/soedar) in abiosoft/colima#1112
-   chore: add second confirmation for container data loss by [@&#8203;jramosf](https://github.com/jramosf) in abiosoft/colima#1113
-   chore: multiple updates by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1122
-   config: make persistence optional with --save-config flag by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1123

#### New Contributors

-   [@&#8203;soedar](https://github.com/soedar) made their first contribution in abiosoft/colima#1112

**Full Changelog**: abiosoft/colima@v0.7.3...v0.7.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colima runs should never overwrite configuration on disk
1 participant