Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dev version of lima #864

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Allow dev version of lima #864

merged 2 commits into from
Nov 15, 2023

Conversation

terev
Copy link
Contributor

@terev terev commented Nov 14, 2023

The latest release of colima made it impossible to use a dev version of lima. This change allows the user to use a dev version but prints a warning.

cmd/start.go Outdated Show resolved Hide resolved
@abiosoft
Copy link
Owner

Thanks for creating this.

As a side note, if you did a git pull --tags prior to running make for Lima, you'd get a version that would pass the version check, because the most recent tag name would be used.

$ limactl --version
limactl version 0.18.0-88-g79cfe42.m

@terev
Copy link
Contributor Author

terev commented Nov 14, 2023

Oh I see, I installed the version of lima using homebrew so it must use a different version. Should the homebrew recipe be changed instead?

@abiosoft
Copy link
Owner

Oh I see, I installed the version of lima using homebrew so it must use a different version. Should the homebrew recipe be changed instead?

I do no think that is needed since this PR would cover both cases. i.e. installing via source or via brew --install HEAD.

core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
@AkihiroSuda
Copy link
Contributor

I suggest to squash commits

abiosoft
abiosoft previously approved these changes Nov 15, 2023
core/core.go Outdated Show resolved Hide resolved
@abiosoft abiosoft self-requested a review November 15, 2023 05:26
@abiosoft abiosoft merged commit ac7e9f6 into abiosoft:main Nov 15, 2023
10 checks passed
@terev terev deleted the allow-dev-lima branch November 15, 2023 22:13
@AkihiroSuda
Copy link
Contributor

@abiosoft Could you consider making a release with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants