WIP: Improve performance #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use more consistent typing on the C++ side: paths are fs::path, strings are std::string * Implement FUSE open/release and avoid opening/closing the file for each read call (as well as the expensive get_real_path!) * Implement FUS opendir/releasedir * Reduce the number of directories that need to be lstat-ed when using readdir by remembering the real path of the root.
|
Also: Thanks for this tool! I was a bit concerned how to unfurl my backup (old long-gone computer!) |
ankon
commented
Mar 12, 2024
| { | ||
| // get the real path | ||
| std::string real_path = get_real_path(path); | ||
|
|
||
| // open the file | ||
| int fd = open(real_path.c_str(), O_RDONLY); | ||
| int fd = open(real_path.c_str(), fi->flags); |
There was a problem hiding this comment.
Reading through this, original code was better I think and more explicit:
Suggested change
| int fd = open(real_path.c_str(), fi->flags); | |
| int fd = open(real_path.c_str(), O_RDONLY); |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use tmfs to extract about 150GiB of data from a time machine backup. While that worked, it was unbearably slow. Looking at the code there were a bunch of "low-hanging fruit".
I'll leave this as a draft for discussion, probably it would be good to clean this up a bit more and split the pure refactorings (such as using fs::path/std::string and the file renamings) from the more functional parts.